Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bare traits 2 #5348

Closed
wants to merge 2 commits into from
Closed

Bare traits 2 #5348

wants to merge 2 commits into from

Conversation

pcwalton
Copy link
Contributor

@pcwalton pcwalton closed this Mar 14, 2013
@pcwalton pcwalton deleted the bare-traits-2 branch March 14, 2013 01:10
flip1995 pushed a commit to flip1995/rust that referenced this pull request Jul 17, 2020
Reprise: new lint: Unintentional return of unit from closures expecting Ord

This lint catches cases where the last statement of a closure expecting
an instance of Ord has a trailing semi-colon. It compiles since the
closure ends up return () which also implements Ord but causes
unexpected results in cases such as sort_by_key.

Fixes rust-lang#5080

Reprise of rust-lang#5348 where I addressed all the comments there

changelog: add lint [`unit_return_expecting_ord`]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant